Speed up test_sorting_s3_nwb_zarr#4537
Closed
chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Closed
Speed up test_sorting_s3_nwb_zarr#4537chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
test_sorting_s3_nwb_zarr#4537chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating the speed regression for full tests from #4515, I noticed that one of our longest tests
test_sorting_s3_nwb_zarrwas slow (before, took 4 minutes here https://github.com/SpikeInterface/spikeinterface/actions/runs/23709486678 and after, took 15 minutes here: https://github.com/SpikeInterface/spikeinterface/actions/runs/24629667731/job/72014705334 - the reason for this regression is still unknown).The reason is that
check_sortings_equalhas to stream the entire file. We can prevent this byframe_sliceing, and only doing acheck_sortings_equalto the time sliced sorting. Should speed our full test suite up by 10%!